Plan 9 from Bell Labs’s /n/sources/patch/applied/tlshand-msgrecv-hcertreq-fix/readme

Copyright © 2009 Alcatel-Lucent.
Distributed under the Lucent Public License version 1.02.
Download the Plan 9 distribution.


fix for the HCertificateRequest in tlshand.c:/^msgRecv

 - use the right sizes for length fields
 - add additional check before the get16 at tlshand.c:1150
 - add   p += nn; n -= nn;
   which were missing after   makebytes at tlshand.c:1145

the latter fixes the problem I had with the test
at tlshand.c:1153 where the (n != nn) part succeeded
while we would want it (would expect it) to fail.

I've not yet tested this on the real system but
 - it feels and looks convincingly ok,
 - it explains the values of n and nn that I saw,
   and, better than that,
 - it checks out with the data I gathered earlier
   while debugging this (unfortunately I have only
   a single sample -- the one from our campus net)

as before, please doublecheck; I'm feeling good about this.

Axel.

Bell Labs OSI certified Powered by Plan 9

(Return to Plan 9 Home Page)

Copyright © 2009 Alcatel-Lucent. All Rights Reserved.
Comments to webmaster@plan9.bell-labs.com.