Changed-lines coverage: PR changed C/C++ lines covered by tests: 91.38% (53/58) Uncovered changed code (with context): ================================================================================ src/Storages/MergeTree/MergeTreeIndexBloomFilterText.cpp ================================================================================ --- uncovered block 339-343 --- 337 | Field converted = tryConvertFieldToType(constant, *actual_type, constant_type.get()); 338 | if (converted.isNull()) >> 339 | return false; 340 | 341 | auto column = actual_type->createColumn(); 342 | if (!column->tryInsert(converted)) >> 343 | return false; 344 | out_bytes = column->getDataAt(0); 345 | return true; --- uncovered block 686-686 --- 684 | String value; 685 | if (!convertConstantToIndexDomain(index_data_types[*key_index], const_source_type, const_value, value)) >> 686 | return false; 687 | out.key_column = *key_index; 688 | out.function = RPNElement::FUNCTION_NOT_EQUALS; --- uncovered block 699-699 --- 697 | String value; 698 | if (!convertConstantToIndexDomain(index_data_types[*key_index], const_source_type, const_value, value)) >> 699 | return false; 700 | out.key_column = *key_index; 701 | out.function = RPNElement::FUNCTION_EQUALS; --- uncovered block 876-876 --- 874 | /// One unconvertible element would under-approximate membership, so decline the whole atom. 875 | if (convert && !convertConstantToIndexDomain(indexed_type, element_type, (*column)[row], converted)) >> 876 | return false; 877 | 878 | bloom_filters.back().emplace_back(params); WARNING: Failed to get start time for [Print Uncovered Code] - start time and duration won't be set --- Coverage counts --- Lines : baseline 934,493/1,080,836 -> current 934,436/1,080,865 (delta -57 / +29) Functions : baseline 806,518/877,901 -> current 806,540/877,901 (delta +22 / +0) Branches : baseline 306,067/389,140 -> current 306,060/389,156 (delta -7 / +16)