Changed-lines coverage: PR changed C/C++ lines covered by tests: 87.64% (78/89) Uncovered changed code (with context): ================================================================================ src/Interpreters/HashJoin/AddedColumns.cpp ================================================================================ --- uncovered block 70-74 --- 68 | const UInt8 * JoinOnKeyColumns::buildRowSkipData(IColumn::Filter & buffer, const ScatteredBlock::Indexes & indexes) const 69 | { >> 70 | return buildRowSkipDataImpl(null_map, join_mask_column, buffer, [&](auto && set_at) 71 | { >> 72 | for (size_t i : indexes.getData()) >> 73 | set_at(i); >> 74 | }); 75 | } 76 | ================================================================================ src/Interpreters/HashJoin/HashJoinMethodsImpl.h ================================================================================ --- uncovered block 451-456 --- 449 | if (mapv.size() > 1 || added_columns.join_on_keys.empty()) 450 | { >> 451 | if (fast_path) >> 452 | return joinRightColumns( >> 453 | std::move(key_getter_vector), mapv, added_columns, used_flags, selector.getIndexes()); 454 | else >> 455 | return joinRightColumns( >> 456 | std::move(key_getter_vector), mapv, added_columns, used_flags, selector.getIndexes()); 457 | } 458 | else --- uncovered block 586-586 --- 584 | { 585 | if constexpr (std::is_same_v, ScatteredBlock::Indexes>) >> 586 | skip_data = join_keys.buildRowSkipData(skip_buffer, selector); 587 | else 588 | skip_data = join_keys.buildRowSkipData(skip_buffer, selector.first, rows); --- uncovered block 695-695 --- 693 | { 694 | if constexpr (std::is_same_v, ScatteredBlock::Indexes>) >> 695 | skip_datas[d] = added_columns.join_on_keys[d].buildRowSkipData(skip_buffers[d], selector); 696 | else 697 | skip_datas[d] = added_columns.join_on_keys[d].buildRowSkipData(skip_buffers[d], selector.first, rows); WARNING: Failed to get start time for [Print Uncovered Code] - start time and duration won't be set --- Coverage counts --- Lines : baseline 887,869/1,033,446 -> current 887,381/1,033,464 (delta -488 / +18) Functions : baseline 951,312/1,026,144 -> current 837,460/912,371 (delta -113,852 / -113,773) Branches : baseline 287,241/367,820 -> current 287,067/367,828 (delta -174 / +8)