Changed-lines coverage: PR changed C/C++ lines covered by tests: 92.08% (244/265) Uncovered changed code (with context): ================================================================================ src/Interpreters/InterpreterRenameQuery.cpp ================================================================================ --- uncovered block 95-95 --- 93 | auto policy = access_control.tryRead(id); 94 | if (policy && (policy->getDatabase() == db) && policy->isForDatabase()) >> 95 | return true; 96 | } 97 | return false; --- uncovered block 165-165 --- 163 | auto policy = access_control.tryRead(rekey.id); 164 | if (!policy) >> 165 | continue; 166 | 167 | RowPolicyName dst_name; --- uncovered block 215-215 --- 213 | auto policy = access_control.tryRead(rekey.id); 214 | if (!policy) >> 215 | continue; 216 | 217 | /// (4) Transient parking name (phase 1 of the apply) is taken by a non-moving policy. --- uncovered block 243-249 --- 241 | return; 242 | >> 243 | throw Exception( >> 244 | ErrorCodes::NOT_IMPLEMENTED, >> 245 | "Cannot move {} to another database {} because a database-wide row policy (ON {}.*) " >> 246 | "applies to it and cannot follow it across databases", >> 247 | backQuoteIfNeed(from_db) + "." + backQuoteIfNeed(from_name), >> 248 | backQuoteIfNeed(to_db), >> 249 | backQuoteIfNeed(from_db)); 250 | } 251 | --- uncovered block 340-354 --- 338 | const auto restore = [&] 339 | { >> 340 | for (const auto & [id, name] : original_names) 341 | { >> 342 | try 343 | { >> 344 | access_control.tryUpdate(id, [&](const AccessEntityPtr & entity, const UUID &) -> AccessEntityPtr 345 | { >> 346 | auto updated = typeid_cast>(entity->clone()); >> 347 | updated->setFullName(name); >> 348 | return updated; >> 349 | }); 350 | } >> 351 | catch (...) 352 | { 353 | /// Best-effort rollback; keep restoring the rest. >> 354 | tryLogCurrentException(getLogger("InterpreterRenameQuery"), "Failed to restore row policy binding during rename rollback"); 355 | } 356 | } --- uncovered block 387-388 --- 385 | catch (...) 386 | { >> 387 | restore(); >> 388 | throw; 389 | } 390 | } WARNING: Failed to get start time for [Print Uncovered Code] - start time and duration won't be set --- Coverage counts --- Lines : baseline 995,938/1,130,179 -> current 995,970/1,130,470 (delta +32 / +291) Functions : baseline 832,434/907,838 -> current 832,649/907,870 (delta +215 / +32) Branches : baseline 323,488/407,184 -> current 323,349/407,298 (delta -139 / +114)