100.00% (61/61) No uncovered changed lines found. === Lost Baseline Coverage: 17 lines === ================================================================================ src/Storages/MergeTree/MergeTreeData.cpp ================================================================================ --- lost coverage block 5273-5273 --- 5271 | (*it_duplicate)->getNameWithState()); 5272 | >> 5273 | if (transaction.txn) 5274 | throw Exception(ErrorCodes::SERIALIZATION_ERROR, "Part {} already exists", (*it_duplicate)->getNameWithState()); 5275 | --- lost coverage block 5276-5276 --- 5274 | throw Exception(ErrorCodes::SERIALIZATION_ERROR, "Part {} already exists", (*it_duplicate)->getNameWithState()); 5275 | >> 5276 | throw Exception(ErrorCodes::DUPLICATE_DATA_PART, "Part {} already exists", (*it_duplicate)->getNameWithState()); 5277 | } 5278 | } ================================================================================ src/Storages/StorageMergeTree.cpp ================================================================================ --- lost coverage block 2143-2143 --- 2141 | /// background cleanup processes like removing of empty parts. 2142 | if (currently_merging_mutating_parts.contains(part)) >> 2143 | return nullptr; 2144 | 2145 | removePartsFromWorkingSet(txn, {part}, clear_without_timeout, parts_lock); ================================================================================ src/Storages/StorageReplicatedMergeTree.cpp ================================================================================ --- lost coverage block 3375-3375 --- 3373 | catch (...) 3374 | { >> 3375 | PartLog::addNewParts(getContext(), PartLog::createPartLogEntries(res_parts, watch.elapsed()), ExecutionStatus::fromCurrentException("", true)); 3376 | 3377 | for (const auto & res_part : res_parts) --- lost coverage block 3377-3378 --- 3375 | PartLog::addNewParts(getContext(), PartLog::createPartLogEntries(res_parts, watch.elapsed()), ExecutionStatus::fromCurrentException("", true)); 3376 | >> 3377 | for (const auto & res_part : res_parts) >> 3378 | unlockSharedData(*res_part); 3379 | 3380 | throw; --- lost coverage block 3380-3380 --- 3378 | unlockSharedData(*res_part); 3379 | >> 3380 | throw; 3381 | } 3382 | --- lost coverage block 4071-4072 --- 4069 | if (e.code == Coordination::Error::ZSESSIONEXPIRED) 4070 | { >> 4071 | restarting_thread.wakeup(); >> 4072 | return; 4073 | } 4074 | --- lost coverage block 8701-8701 --- 8699 | else 8700 | { >> 8701 | if (parts_should_be_retried) 8702 | parts_should_be_retried->insert(part_names[i]); 8703 | --- lost coverage block 8704-8705 --- 8702 | parts_should_be_retried->insert(part_names[i]); 8703 | >> 8704 | if (!Coordination::isHardwareError(response.error)) >> 8705 | LOG_WARNING(log, "Cannot remove part {} from ZooKeeper: {}", part_names[i], Coordination::errorMessage(response.error)); 8706 | } 8707 | } --- lost coverage block 10028-10030 --- 10026 | if (queue.isGoingToBeDropped(MergeTreePartInfo::fromPartName(part_name, format_version), &covering_drop_range)) 10027 | { >> 10028 | LOG_WARNING(log, "Do not enqueue part {} for check because it's covered by drop range {} and going to be removed", >> 10029 | part_name, covering_drop_range.getPartNameForLogs()); >> 10030 | return; 10031 | } 10032 | part_check_thread.enqueuePart(part_name, delay_to_check_seconds); --- lost coverage block 11249-11250 --- 11247 | catch (const Exception & ex) 11248 | { >> 11249 | LOG_WARNING(log, "Cannot commit empty part {} with error {}", lost_part_name, ex.displayText()); >> 11250 | return false; 11251 | } 11252 | WARNING: Failed to get start time for [Print Uncovered Code] - start time and duration won't be set --- Coverage counts --- Lines : baseline 762,893/907,547 -> current 763,627/907,562 (delta +734 / +15) Functions : baseline 831,316/912,661 -> current 831,423/912,662 (delta +107 / +1) Branches : baseline 248,404/324,674 -> current 248,623/324,680 (delta +219 / +6)